Skip to content

Conversation

@isegall-da
Copy link
Contributor

@isegall-da isegall-da commented Jun 9, 2025

Fixes #1044

Test on a fork from a non-contributor GH user: https://github.com/hyperledger-labs/splice/actions/runs/15539346462/job/43746160586 (fails on a FIXME that enabled it to run against this PR rather than against main, but otherwise works)

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@isegall-da isegall-da force-pushed the isegall/fix-fork-ci branch 2 times, most recently from a2f94ac to f3f9b92 Compare June 9, 2025 16:39
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
@isegall-da isegall-da force-pushed the isegall/fix-fork-ci branch from f3f9b92 to 0c044ab Compare June 9, 2025 16:40
@isegall-da isegall-da enabled auto-merge (squash) June 9, 2025 16:51
@isegall-da isegall-da disabled auto-merge June 9, 2025 16:51
@isegall-da isegall-da enabled auto-merge (squash) June 9, 2025 16:51
@isegall-da isegall-da merged commit 1b4863d into main Jun 9, 2025
41 checks passed
@isegall-da isegall-da deleted the isegall/fix-fork-ci branch June 9, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci on forks are broken

3 participants